On Tue, Dec 01, 2015 at 04:09:48PM +0100, Paolo Bonzini wrote: > > > On 01/12/2015 03:18, Peter Xu wrote: > > I think (2) is better in term of lines of codes (and also > > clear). However I may need to keep the QMP interface (to keep the > > has_detach parameter in qmp_dump_guest_memory), so I'd like to > > choose (1). > > It's also okay to also pass has_detach = true to qmp_dump_guest_memory.
Yes. That's more clear. Will put it into v5. Thanks. Peter > > Paolo
