On 12/03/2015 09:37 AM, Markus Armbruster wrote: > It should only be created via spapr_dr_connector_new(). Attempting to > create it with -device crashes. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > --- > hw/ppc/spapr_drc.c | 4 ++++ > 1 file changed, 4 insertions(+)
For 2.5, this is an appropriate last-minute crash-avoider. The FIXME
reminds us to do better in 2.6.
Reviewed-by: Eric Blake <ebl...@redhat.com>
>
> diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
> index dad157f..8be62c3 100644
> --- a/hw/ppc/spapr_drc.c
> +++ b/hw/ppc/spapr_drc.c
> @@ -599,6 +599,10 @@ static void spapr_dr_connector_class_init(ObjectClass
> *k, void *data)
> drck->attach = attach;
> drck->detach = detach;
> drck->release_pending = release_pending;
> + /*
> + * Reason: it crashes FIXME find and document the real reason
> + */
> + dk->cannot_instantiate_with_device_add_yet = true;
> }
>
> static const TypeInfo spapr_dr_connector_info = {
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
