On Thu, Dec 03, 2015 at 03:22:09PM +0100, Markus Armbruster wrote: > Watch this: > > $ qemu-system-ppc64 -nodefaults -S -display none -device > spapr-dr-connector > ** > ERROR:/home/armbru/work/qemu/hw/ppc/spapr_drc.c:45:get_type_shift: > assertion failed: (is_power_of_2(type)) > Aborted (core dumped) > > It may not make sense, but it shouldn't crash. Should this device be > available with -device / device_add?
No, it shouldn't. In fact, I'm not sure it makes sense for these to be standalone QOM objects at all - I haven't looked into the details enough, but I suspect this would make more sense as a QOM interface on existing devices. > > For what it's worth, help works: > > $ qemu-system-ppc64 -nodefaults -S -display none -device > spapr-dr-connector,help > spapr-dr-connector.indicator-state=uint32 > spapr-dr-connector.name=string > spapr-dr-connector.id=uint32 > spapr-dr-connector.entity-sense=uint32 > spapr-dr-connector.isolation-state=uint32 > spapr-dr-connector.allocation-state=uint32 > spapr-dr-connector.index=uint32 > spapr-dr-connector.connector_type=uint32 > spapr-dr-connector.fdt=struct > -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature