On 2015-12-03 13:19, Aurelien Jarno wrote: > On 2015-12-02 10:36, Richard Henderson wrote: > > On 12/01/2015 08:32 AM, Aurelien Jarno wrote: > > >On 2015-12-01 08:19, Richard Henderson wrote: > > >>If there are a lot of guest memory ops in the TB, the amount of > > >>code generated by tcg_out_tb_finalize could be well more than 1k. > > >>In the short term, increase the reservation larger than any TB > > >>seen in practice. > > >> > > >>Reported-by: Aurelien Jarno <aurel...@aurel32.net> > > >>Signed-off-by: Richard Henderson <r...@twiddle.net> > > > > > >Thanks! I was testing the same patch locally after our discussion, and I > > >confirm it fixes the issue. > > > > Here's the proper patch for 2.6. If you'd like to run it through your same > > tests, please? > > The patch looks fine to me, the only tiny nitpick I have is that you can > return a bool instead of a hint. > > I am currently testing it (which is basically running a glibc build and > testsuite multiple time in a VM), I'll let you know the result by > tomorrow. In the meantime, you can add: > > Reviewed-by: Aurelien Jarno <aurel...@aurel32.net>
I haven't seen any crash so far, which is more time than it usually needs to trigger the issue. So I guess we can consider that the patch is correct. Therefore: Tested-by: Aurelien Jarno <aurel...@aurel32.net> -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel...@aurel32.net http://www.aurel32.net
