2015-12-04 21:18 GMT+08:00 Eric Blake <ebl...@redhat.com>:
> On 12/04/2015 02:19 AM, Miao Yan wrote:
>> Vmxnet3 uses the following debug macro style:
>>
>
> When sending a patch series, it's best to include a 0/2 cover letter
> (some of the maintainer tooling works better if it can reply to the
> cover letter).
>
> Also, this patch depends on your earlier patch "net/vmxnet3.c: fix a
> build error when enabling debug output" in order to not cause a
> temporary compile failure; you should state that dependency so that the
> patches get applied in the correct order. (Or just make the series be 3
> patches, with that one as 1/3)
I thought trivial patches like these don't need a cover letter. I'll
send v2 with your reviewed-by tag. Thanks.
>
>> #ifdef SOME_DEBUG
>> # define debug(...) do{ printf(...); } while (0)
>> # else
>> # define debug(...) do{ } while (0)
>> #endif
>>
>> If SOME_DEBUG is undefined, then format string inside the
>> debug macro will never be checked by compiler. Code will
>> likely to break in the future when SOME_DEBUG is enabled
>
> s/will/is
Thanks. Will fix.
>
>> because of lacking of testing. This patch changes this
>
> s/lacking/lack/
Thanks. Will fix.
>
>> to the following:
>>
>> #define debug(...) \
>> do { if (SOME_DEBUG_ENABLED) printf(...); } while (0)
>>
>> Signed-off-by: Miao Yan <yanmiaob...@gmail.com>
>> ---
>> hw/net/vmxnet_debug.h | 139
>> +++++++++++++++++++++++++++++++-------------------
>> 1 file changed, 86 insertions(+), 53 deletions(-)
>>
>
> Changes themselves look okay, so with the commit message grammar improved,
>
> Reviewed-by: Eric Blake <ebl...@redhat.com>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
