Hi On Thu, Dec 10, 2015 at 3:51 AM, Eric Blake <ebl...@redhat.com> wrote: > On 12/09/2015 05:53 PM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau <marcandre.lur...@redhat.com> >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) > > NACK. 'type' is POSIX, and shellcheck is buggy. > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/type.html
So is checkbashisms then. I am just spreading that wrong idea then :) > >> >> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/configure b/configure >> index ba57b3f..90eff82 100755 >> --- a/configure >> +++ b/configure >> @@ -158,7 +158,7 @@ symlink() { >> # check whether a command is available to this shell (may be either an >> # executable or a builtin) >> has() { >> - type "$1" >/dev/null 2>&1 >> + which "$1" >/dev/null 2>&1 > > Conversely, 'which' is _not_ POSIX, and therefore less portable than 'type'. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > -- Marc-André Lureau