Peter Maydell <peter.mayd...@linaro.org> writes: > On 10 December 2015 at 10:29, Markus Armbruster <arm...@redhat.com> wrote: >> Device init() methods aren't supposed to call hw_error(), they should >> report the error and fail cleanly. Do that. >> >> Cc: Peter Maydell <peter.mayd...@linaro.org> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> > > These are all really "QEMU bug" error paths -- the only place > that uses omap_i2c is the omap SoC init, you can't create the > device on the command line, and so we'll only get these errors > if there's a bug in a function like omap2420_mpu_init. But > I don't object to the patch in principle.
All callers use qdev_init_nofail(), so this patch merely converts the hw_error() crash into an &error_abort crash. Improvement, because now it crashes closer to where the bug is. I can spell that out in the commit message if you like. > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org> Thanks!
