-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256
On 11/12/2015 14:42, Eric Blake wrote: >>> compiles and is pretty much a 1:1 translation from the qjson.c >>> API to the visitor API (using this patch as a guide). Feel >>> free to include it and remove qjson.c. Alternatively, you can >>> leave out this patch and I'll test and submit the transition. > Should I squash the two together, or keep my current patch and > drop qjson.c as a separate patch? As you prefer. > Also, while reading this, I noticed that qjson.h has signatures > that match JSON ('name' comes before 'value', when generating a > "name":value pair), while visitor.h has signatures that are > backwards ('obj' comes before 'name', even though the output will > be "name":value-of-obj). I'm seriously debating about a tree-wide > coccinelle patch to reverse the order or arguments of all the > visit_type_* functions. That would be doable, there aren't many users outside generated code. Paolo -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWatN5AAoJEL/70l94x66D8PQIAKEzIEUqjfhDMLhov4NwxGs3 LvyW+/w5AyDEZOJMayBuc3y7fSTbLp/eMQPsfBOIvBCMr/aEE4Tij0CzW3JE4FnH IFCW94F8Q7vq8jTYKFU6222Nk7vUGOLG9y3jQSnLX4RzpRizhWjk73DtkED7YVu3 5J0Ef3+ZEobCZA9zOwQT7+pqc9ah/M6tGsZodvML2FopCk/SsTBauPjoSeP0knHE 1MJsu/KVjn1508yn1SY9d0HJKQx2dM3nzQRtp0xbWx7x8o7u826axpVQieq7YBpb PaRW/vqiXvdnRkrCRHZAL6PJ4GLyquX42E7HjqCQjibA06fbtqmLoYQA2A/2Pyg= =EJIn -----END PGP SIGNATURE-----