On Thu, 10 Dec 2015 13:12:30 +0100 Janosch Frank <fran...@linux.vnet.ibm.com> wrote:
> Kvm_stat is a very helpful script for checking the state of VMs, but > when I tried to introduce new features it broke every few lines. > > This patch series aims to make the script more readable and durable, > so future additions to it will break it less likely. It also fixes > input/output problems for all of its interface modes. > > Testing was done rarely on X86_64 RHEL 6.7 and mostly on s390. Tests > on other architectures would be beneficial. The cleanup and fixes look good to me, but I'm most certainly not a python expert :) Paolo, would you take these through the kvm tree? > > Janosch Frank (34): > scripts/kvm/kvm_stat: Cleanup of multiple imports > scripts/kvm/kvm_stat: Replaced os.listdir with os.walk > scripts/kvm/kvm_stat: Make constants uppercase > scripts/kvm/kvm_stat: Removed unneeded PERF constants > scripts/kvm/kvm_stat: Mark globals in functions > scripts/kvm/kvm_stat: Invert dictionaries > scripts/kvm/kvm_stat: Cleanup of path variables > scripts/kvm/kvm_stat: Improve debugfs access checking > scripts/kvm/kvm_stat: Introduce main function > scripts/kvm/kvm_stat: Fix spaces around keyword assignments > scripts/kvm/kvm_stat: Rename variables that redefine globals > scripts/kvm/kvm_stat: Moved DebugfsProvider > scripts/kvm/kvm_stat: Fixup syscall error reporting > scripts/kvm/kvm_stat: Set sensible no. files rlimit > scripts/kvm/kvm_stat: Cleanup of platform detection > scripts/kvm/kvm_stat: Make cpu detection a function > scripts/kvm/kvm_stat: Rename _perf_event_open > scripts/kvm/kvm_stat: Introduce properties for providers > scripts/kvm/kvm_stat: Cleanup of TracepointProvider > scripts/kvm/kvm_stat: Cleanup cpu list retrieval > scripts/kvm/kvm_stat: Encapsulate filters variable > scripts/kvm/kvm_stat: Cleanup of Stats class > scripts/kvm/kvm_stat: Cleanup of Groups class > scripts/kvm/kvm_stat: Cleanup of Event class > scripts/kvm/kvm_stat: Group arch specific data > scripts/kvm/kvm_stat: Remove unneeded X86_EXIT_REASONS > scripts/kvm/kvm_stat: Make tui function a class > scripts/kvm/kvm_stat: Fix output formatting > scripts/kvm/kvm_stat: Move to argparse and add description > scripts/kvm/kvm_stat: Cleanup and pre-init perf_event_attr > scripts/kvm/kvm_stat: Read event values as u64 > scripts/kvm/kvm_stat: Fix rlimit for unprivileged users > scripts/kvm/kvm_stat: Fixup filtering > scripts/kvm/kvm_stat: Add interactive filtering > > scripts/kvm/kvm_stat | 1129 > ++++++++++++++++++++++++++++---------------------- > 1 file changed, 626 insertions(+), 503 deletions(-) >
