On 16/12/2015 22:45, Alistair Francis wrote: > + > + /* Rename each SPI bus after the SPI device to allow the board > + * to access all of the busses from the SoC. > + */ > + spi_bus = qdev_get_child_bus(DEVICE(&s->spi[i]), "spi0"); > + snprintf(bus_name, 6, "spi%d", i); > + qdev_bus_rename(spi_bus, bus_name); > + > + /* Add the SPI buses to the SoC child bus */ > + /* FIXME: This causes the later buses to be duplicated in > + * the SPI devices printout when running qtre. > + */ > + QLIST_INSERT_HEAD(&dev->child_bus, spi_bus, sibling);
Isn't the SPI bus accessible with something similar to spi[0-5]/spi0, even without this hack? In any case, I would prefer qdev_bus_rename to stay in xlnx-zynqmp.c. Paolo
