On 18 December 2015 at 12:52, Markus Armbruster <arm...@redhat.com> wrote: > Cao jin <caoj.f...@cn.fujitsu.com> writes: > >> There is TYPE_ICH9_AHCI definition in ahci.h when QOMify it, seems it >> is missed.
> I suspect there are more instances of the same problem. > Not sure how interested we are in consistent use of these macros... In a lot of cases we'd need to find somewhere appropriate to put the TYPE_* macro which might well mean creating a new header file just for the purpose. That seems like overkill... thanks -- PMM