Re: [Qemu-devel] [PATCH] macio: fix overflow in lba to offset conversion for ATAPI devices

[P J P]

+-- On Mon, 4 Jan 2016, Mark Cave-Ayland wrote --+
|      /* Calculate current offset */
| -    offset = (int64_t)(s->lba << 11) + s->io_buffer_index;
| +    offset = ((int64_t)(s->lba) << 11) + s->io_buffer_index;

Maybe ((int64_t)s->lba << 11) ? No parenthesis around s->lba.

--
 - P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F