Re: [Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms

[P J P]

+-- On Wed, 6 Jan 2016, Michal Privoznik wrote --+
|      }
| -    if (!blk_is_inserted(conf->conf.blk)) {
| +
| +    dinfo = blk_legacy_dinfo(conf->conf.blk);
| +    if (!((dinfo && dinfo->media_cd) ||
| +          blk_is_inserted(conf->conf.blk))) {
|          error_setg(errp, "Device needs media, but drive is empty");
|          return;
|      }

  The if expression seems little confusing; Maybe

 ->  if (dinfo && !dinfo->media_cd && !blk_is_inserted(conf->conf.blk))

--
 - P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F