On 01/06/2016 03:37 PM, Mark Cave-Ayland wrote:
> Make sure that we include the value of dma_active in the migration stream.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayl...@ilande.co.uk>
> ---
> hw/ide/macio.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ide/macio.c b/hw/ide/macio.c
> index 560c071..695d4d2 100644
> --- a/hw/ide/macio.c
> +++ b/hw/ide/macio.c
> @@ -518,11 +518,12 @@ static const MemoryRegionOps pmac_ide_ops = {
>
> static const VMStateDescription vmstate_pmac = {
> .name = "ide",
> - .version_id = 3,
> + .version_id = 4,
> .minimum_version_id = 0,
> .fields = (VMStateField[]) {
> VMSTATE_IDE_BUS(bus, MACIOIDEState),
> VMSTATE_IDE_DRIVES(bus.ifs, MACIOIDEState),
> + VMSTATE_BOOL(dma_active, MACIOIDEState),
> VMSTATE_END_OF_LIST()
> }
> };
>
Did you wind up ever observing this value to be non-zero when it was
written to the migration stream?
I really did think that we should be able to assume this was always
false due to how migration will drain all outstanding AIO, but maybe I
am mistaken.
--js
