On 06/03/10 22:58, Richard Henderson wrote:
> On 06/03/2010 09:48 AM, jes.soren...@redhat.com wrote:
>> +/*
>> + * Duplicate definition from vl.c to avoid messing up the entire build
>> + */
>> +enum {
>> +#define DEF(option, opt_arg, opt_enum, opt_help, arch_mask) \
>> + opt_enum,
>> +#define DEFHEADING(text)
>> +#include "qemu-options.h"
>> +#undef DEF
>> +#undef DEFHEADING
>> +#undef GEN_DOCS
>> +};
>
> There's no header file you can put this in? Or invent to put this in?
> Cause this is really kinda gross...
>
The problem is that it requires qemu-options.h to be included, which
isn't included per default for all the files. If I put it into sysemu.h
at least it's going to require making every .c file build with those flags.
I agree it's gross, but I am not sure what would be a better solution.
>> + default:
>> + ret = -1;
>> + }
>> + return ret;
>> +}
>
> Why have a return value at all...
>
>> + default:
>> + os_parse_cmd_args(popt, optarg);
>
> ... if you're going to ignore the results?
I was trying to make it forward looking, but yeah we can just kill that.
Cheers,
Jes
