On Thu, Jan 14, 2016 at 04:41:03PM +0800, Fam Zheng wrote: > Create a coroutine in nbd_client_new, so that nbd_send_negotiate doesn't > need qemu_set_block(). > > Handlers need to be set temporarily for csock fd in case the coroutine > yields during I/O. > > With this, if the other end disappears in the middle of the negotiation, > we don't block the whole event loop. > > To make the code clearer, unify all function names that belong to > negotiate, so they are less likely to be misused. This is important > because we rely on negotiation staying in main loop, as commented in > nbd_negotiate_read/write().
To nit-pick, is generally better to do such generic renaming of existing code separately from commits which include functional changes > > Signed-off-by: Fam Zheng <f...@redhat.com> > --- > nbd/server.c | 150 > ++++++++++++++++++++++++++++++++++++++++------------------- Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
