On Mon, 18 Jan 2016 20:37:58 +0300 Michael Tokarev <m...@tls.msk.ru> wrote:
> 11.01.2016 20:30, Greg Kurz wrote: > > > -virtio_balloon_handle_output(const char *name, uint64_t gpa) "section > > name: %s gpa: %"PRIx64"" > > +virtio_balloon_handle_output(const char *name, uint64_t gpa) "section > > name: %s gpa: %"PRIx64 > ... > > I'm not sure what's the value of this. It's fine either way, no? The only value is to drop unneeded stuff... and maybe some consistency with the traces that don't have these trailing empty strings. > Do we have a rule for trailing empty strings in coding style? :) > Nor we have against parenthesitis, which brings a lot more unneeded characters into the code :P More seriously, I posted this because it was discussed earlier this month. But honestly, I don't care if you don't want to push it. :) > Thanks, > > /mjt > Cheers. -- Greg
