On Mon, Jan 18, 2016 at 06:45:14PM +0100, Andreas Färber wrote: > Am 18.01.2016 um 05:39 schrieb David Gibson: > > Functions of type FindSysbusDeviceFunc currently return an integer. I > > recently made an error in a patch because I assumed that this return value > > would control whether iteration of the function across devices continues > > or not. In fact, the function's return value is always ignored. > > > > This changes the function type to return void, so that others don't make > > the same mistake. > > Have you considered implementing the behavior you expected? :) > Not necessary for your use case or too complicated?
A bit of both.
> > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au>
> > ---
> >
> > Please apply.
>
> Patch looks okay, too short notice for today's pull though.
> Usually we avoid "I" in a commit message.
True, that probably won't make so much sense sitting in the commit
history. I'll reword and resend.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
