On 19 January 2016 at 07:27, Markus Armbruster <arm...@redhat.com> wrote: > Peter Maydell <peter.mayd...@linaro.org> writes: > >> On 11 January 2016 at 15:19, Daniel P. Berrange <berra...@redhat.com> wrote: >>> I think even guest-agent code & tests could include it in order to >>> get clean includes, even if they don't use any of the QEMU functions >>> defined in it. So I think its simplest to just say every .c file must >>> use it and leave it at that. >> >> OK, let's assume that works. > > If it doesn't, we need a header with just configuration results that is > included in every .c file first. Just like config.h should be when > using autoconf.
An example of the kind of code that I wasn't sure about is the stuff in tests/tcg/mips/ -- this currently doesn't include any QEMU headers that I can see and I don't think they're even on the include path. In any case I'll do the obvious stuff first and circle back to the oddball standalone sources later. thanks -- PMM
