David Gibson <da...@gibson.dropbear.id.au> writes: > On Tue, Jan 19, 2016 at 08:44:51AM +0100, Markus Armbruster wrote: >> David Gibson <da...@gibson.dropbear.id.au> writes: >> >> > The functions for migrating the hash page table on pseries machine type >> > (htab_save_setup() and htab_load()) can report some errors with an >> > explicit fprintf() before returning an appropriate error code. Change >> > these >> > to use error_report() instead. >> > >> > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> >> > Reviewed-by: Thomas Huth <th...@redhat.com> >> > --- >> > hw/ppc/spapr.c | 12 ++++++------ >> > 1 file changed, 6 insertions(+), 6 deletions(-) >> > >> > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c >> > index 3cfacb9..1eb7d03 100644 >> > --- a/hw/ppc/spapr.c >> > +++ b/hw/ppc/spapr.c >> >> Lost this hunk: >> >> @@ -1309,8 +1309,9 @@ static int htab_save_setup(QEMUFile *f, void *opaque) >> spapr->htab_fd = kvmppc_get_htab_fd(false); >> spapr->htab_fd_stale = false; >> if (spapr->htab_fd < 0) { >> - fprintf(stderr, "Unable to open fd for reading hash table >> from KVM: %s\n", >> - strerror(errno)); >> + error_report( >> + "Unable to open fd for reading hash table from KVM: %s", >> + strerror(errno)); >> return -1; >> } >> } >> >> Intentional? > > Yes. As noted in the cover letter, this conflicts with another series > I'm working on, which will obsolete this change anyway.
The patch doesn't quite hold what the commit message's promises, but I guess that's okay. An "except for htab_save_setup()" in the commit message wouldn't hurt, though.