Hi Marcel,

On Tue, 19 Jan 2016 16:26:31 +0200, marcel.apfelb...@gmail.com wrote:
> >
> > +/* DSN */
> > +#define PCI_DSN_VER                     1
> > +#define PCI_DSN_SIZEOF                  8
> 
> Are you sure the size of DSN is 8?
> Looking at PCIe spec 3, chapter 7.12 I see 12, but I might be wrong.

Total size (DSN ext. cap header + Serial Number register) is indeed 12.
The Serial Number register itself is 64 bits.

Newer qemu already has PCI_EXT_CAP_DSN_SIZEOF defined as 12
(in standard-headers/linux/pci_regs.h)

We may choose better naming to reflect the '8 size' refers to the
payload.

Reply via email to