On 01/19/2016 11:51 PM, John Snow wrote: > Change the floppy drive type to a QAPI enum type, to allow us to > specify the floppy drive type from the CLI in a forthcoming patch. > > Signed-off-by: John Snow <js...@redhat.com> > --- > hw/block/fdc.c | 80 > +++++++++++++++++++++++++------------------------- > hw/i386/pc.c | 17 ++++++----- > include/hw/block/fdc.h | 9 +----- > qapi/block.json | 16 ++++++++++ > 4 files changed, 66 insertions(+), 56 deletions(-) >
> +++ b/qapi/block.json
> @@ -40,6 +40,22 @@
> 'data': ['auto', 'none', 'lba', 'large', 'rechs']}
>
> ##
> +# @FloppyDriveType
> +#
> +# Type of Floppy drive to be emulated by the Floppy Disk Controller.
> +#
> +# @144: 1.44MB 3.5" drive
> +# @288: 2.88MB 3.5" drive
> +# @120: 1.5MB 5.25" drive
Umm, how does 120 match with 1.5M? Elsewhere the code comments say:
/* 1.2 MB 5"1/4 floppy disks */
With the typo fixed,
Reviewed-by: Eric Blake <ebl...@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
