On 01/21/2016 04:56 AM, Daniel P. Berrange wrote: > The gd_vc_handler() callback is using g_malloc0() to > allocate the CharDriverState struct. As a result the > logfd field is getting initialized to 0, instead of > -1 when no logfile is requested. > > The result is that when running > > $ qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0 > > qemu duplicates all monitor output to stdout as well > as the GTK window. > > Not using qemu_chr_alloc() was already a bug, but harmless > until this commit > > commit d0d7708ba29cbcc343364a46bff981e0ff88366f > Author: Daniel P. Berrange <berra...@redhat.com> > Date: Mon Jan 11 12:44:41 2016 +0000 > > qemu-char: add logfile facility to all chardev backends > > which exposed the problem as a behaviour regression > > Reported-by: Hervé Poussineau <hpous...@reactos.org> > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > --- > ui/gtk.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
