On 01/22/2016 05:15 AM, Valentin Rakush wrote: > This patch adds support for qom-type-prop-list command to list object > class properties. A later patch will use this functionality to > implement x86_64-cpu properties. > > Signed-off-by: Valentin Rakush <valentin.rak...@gmail.com> > Cc: Luiz Capitulino <lcapitul...@redhat.com> > Cc: Eric Blake <ebl...@redhat.com> > Cc: Markus Armbruster <arm...@redhat.com> > Cc: Andreas Färber <afaer...@suse.de> > Cc: Daniel P. Berrange <berra...@redhat.com> > ---
> +++ b/hmp-commands.hx
> @@ -1734,6 +1734,19 @@ Print QOM properties of object at location @var{path}
> ETEXI
>
> {
> + .name = "qom-type-prop-list",
To be consistent with most existing HMP commands, this should use
qmp_type_prop_list (only the QMP version should use '-').
For that matter, should this really be a new top-level command, or
should it be a subcommand of the 'info' command?
The QMP command looks fine, though.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
