On 01/25/2016 03:43 PM, Peter Maydell wrote: > On 25 January 2016 at 14:34, Peter Maydell <peter.mayd...@linaro.org> wrote: >> On 25 January 2016 at 14:09, Eric Auger <eric.au...@linaro.org> wrote: >>> Hi Peter, >>> On 01/25/2016 03:05 PM, Peter Maydell wrote: >>>> On 18 January 2016 at 15:16, Eric Auger <eric.au...@linaro.org> wrote: >> >>>> Don't we want to return here, rather than continuing with the >>>> rest of the function? ("goto err;" with an err: label before >>>> the g_free() at the bottom of the function probably best since >>>> some of the error paths need to free that.) >>> due to the &error_fatal, we are going to exit here. I thought it is not >>> worth going further if we can't find the clock node. >> >> Yes, sorry, I didn't notice the error_fatal til I got to about >> the last patch I reviewed. You can ignore similar comments >> I made about some of the other patches. > > ...so if you fix the 'asserts' comment thing, you can have > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
OK thanks for the whole review Eric > > thanks > -- PMM >