Re: [Qemu-devel] [PATCH v11 2/7] hw/ptimer: Perform counter wrap around if timer already expired

[Dmitry Osipenko]

Hello Peter,

24.01.2016 08:29, Peter Crosthwaite пишет:
[snip]

+            if (expired && (counter != 0)) {
+                /* Wrap around periodic counter.  */
+                counter = s->limit - counter % s->limit;
+            }

Noticed another nit here. This should be:

counter = s->limit - (counter - 1) % s->limit;

So wraparound for counter = -1 is counter = limit (not limit - 1). Will fix it 
in V12.

I suppose your r-b is still valid, otherwise please let me know.

--
Dmitry