On 01/26/2016 05:44 PM, Hailiang Zhang wrote: > On 2016/1/26 16:59, Zhang Chen wrote: >> From: ZhangChen <zhangchen.f...@cn.fujitsu.com> >> >> Traffic-mirrorer is a plugin of netfilter. >> It make qemu has ability to copy and mirror guest's >> net packet. we output packet to chardev. >>
>> +static void traffic_mirrorer_setup(NetFilterState *nf, Error **errp)
>> +{
>> + MirrorerState *s = FILTER_TRAFFIC_MIRRORER(nf);
>> +
>> + if (!s->outdev) {
>> + error_setg(errp, "filter traffic mirrorer needs 'outdev'
>> property set!"
>> + "property set!");
>
> Duplicate 'property set!'.
For that matter, error_setg() messages should never end in '!'.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
