Peter Maydell writes: > On 28 January 2016 at 20:36, Lluís Vilanova <vilan...@ac.upc.edu> wrote: >> The LTTng tracing backend includes the system's "syscall.h", but QEMU >> replaces it with its own for linux-user builds. This results in a double >> include on some targets (when LTTng is enabled). >> >> Signed-off-by: Lluís Vilanova <vilan...@ac.upc.edu>
> Adding include guards is fine, but it sounds to me like what we > should actually do to fix this confusion is rename all the linux-user > local headers to target_syscall.h. Hmmm, I didn't know if using the same name was on purpose or not. If the intention was *not* to override the system's syscall.h, then a rename is the proper solution. Can you or someone else confirm this? Thanks, Lluis
