On Mon, Jun 07, 2010 at 11:52:05AM -0500, Anthony Liguori wrote: > On 06/07/2010 11:42 AM, Paul Brook wrote: >>> On Mon, Jun 07, 2010 at 05:16:30PM +0100, Paul Brook wrote: >>> >>>>> With -netdev, there now seems to be little need to support vlans, >>>>> enabling them leads to user confusion and bad performance. >>>>> Disable support for vlans by default, add config option to enable. >>>>> >>>> No. If you want to remove vlans, then actually do that. >>>> >>> How is this not what this patch does? You mean kill the code >>> completely, not just --contigure option? >>> >> Yes. Configure options are bad. If code isn't worth enabling by default then >> you've got to have a very good reason why it exists at all. >> > > Configure options are bad except when they are good. > > Distributions don't want to support every possible bell and whistle that > qemu supports. By having configuration options upstream, we ensure that > everyone is consistently disabling thing in the same fashion and that > the interfaces presented to the users are consistent. > > I certainly believe that we should not disable features by default. But > I think it's important that we support disabling features from a > downstream supportability perspective. > > Regards, > > Anthony Liguori
So I see two ways to go forward: switch default value in my patch, or disable vlans unconditionally. Which will it be? >> Paul >> >>