On 31/01/16 21:57, Paolo Bonzini wrote: > On 31/01/2016 18:54, Peter Maydell wrote: >> On 31 January 2016 at 17:19, Paolo Bonzini <pbonz...@redhat.com> wrote: >>> On 31/01/2016 16:54, Mark Cave-Ayland wrote: >>>> I also notice that with the above commit I lose cycling through history >>>> in the GTK monitor - even with the multiple echo, instead of the up/down >>>> arrow keys cycling through the history instead I see the codes ^[[B and >>>> ^[[A being output to the window instead. >>> >>> That is probably me. The echo feature was introduced for QMP, but in >>> theory it should have been limited to that. I'll check it, thanks. >> >> I've also seen echo, but only intermittently... > > That smells like uninitialized memory or something like that. > > Actually I'm fairly sure I tested "-monitor vc" at least, so perhaps > it's an interaction between the echo feature and "qemu-char: add logfile > facility to all chardev backends". Anyway I'll look at it.
Yeah I think you're right. I did a little bit of testing yesterday and the echo disappeared until I remembered that I'd been testing a self-built OpenBIOS - and as soon as I reintroduced this option onto the command line, the echo magically re-appeared. I can reproduce this consistently under qemu-system-ppc git master like this: make distclean STRIP= './configure' '--target-list=ppc-softmmu' '--prefix=/home/build/rel-qemu-git' '--enable-gtk' '--disable-pie' and then specifying a -bios parameter on the command line (even if it is the same file as that normally used by QEMU): $ ./qemu-system-ppc -bios ../share/qemu/openbios-ppc Now try typing into the GTK monitor window and hopefully you should be able to see the problem. ATB, Mark.
