Markus Armbruster <arm...@redhat.com> writes: > Marc-André Lureau <marcandre.lur...@gmail.com> writes: > >> Hi >> >> On Fri, Jan 29, 2016 at 4:43 PM, Markus Armbruster <arm...@redhat.com> wrote: >>> The existing users pass a func that saves dev, and free the saved dev >>> later. Works as long as we call func() at most once. If multiple >>> devices match, all but the last one are leaked. Can this happen? >> >> It is the responsability of the func() callback to deal with multiple >> matches. > > If that's the case, and multiple devices can match, then the callbacks > are all broken. > >> I don't think this needs to change. > > If you mean to say that you don't have to fix it in this series: yes, > but it still needs fixing. If you don't want to fix it, consider adding > a FIXME comment.
I'll have some ivshmem work coming up, and will try to remember to include a fix for this. [...]
