On Wed, Feb 03, 2016 at 11:00:51AM +0100, Markus Armbruster wrote: > David Gibson <da...@gibson.dropbear.id.au> writes: > > > At present, the core device model code for 8250-like serial ports > > (serial.c) and the code for serial ports attached to ISA-style legacy IO > > (serial-isa.c) are both controlled by the CONFIG_SERIAL variable. > > > > There are lots and lots of embedded platforms that have 8250-like serial > > ports but have never had anything resembling ISA legacy IO. Therefore, > > split serial-isa into its own CONFIG_SERIAL_ISA option so it can be > > disabled for platforms where it's not appropriate. > > > > For now, I enabled CONFIG_SERIAL_ISA in every default-config where > > CONFIG_SERIAL is enabled, excepting microblaze, moxie, or32, and > > xtensa. As best as I can tell, those platforms never used legacy ISA, > > and also don't include PCI support (which would allow connection of a > > PCI->ISA bridge and/or a southbridge including legacy ISA serial > > ports). > > > > Signed-off-by: David Gibson <da...@gibson.dropbear.id.au> > > --- > > default-configs/alpha-softmmu.mak | 1 + > > default-configs/arm-softmmu.mak | 1 + > > default-configs/i386-softmmu.mak | 1 + > > default-configs/mips-softmmu.mak | 1 + > > default-configs/mips64-softmmu.mak | 1 + > > default-configs/mips64el-softmmu.mak | 1 + > > default-configs/mipsel-softmmu.mak | 1 + > > default-configs/ppc-softmmu.mak | 1 + > > default-configs/ppc64-softmmu.mak | 1 + > > default-configs/ppcemb-softmmu.mak | 1 + > > default-configs/sh4-softmmu.mak | 1 + > > default-configs/sh4eb-softmmu.mak | 1 + > > default-configs/sparc64-softmmu.mak | 1 + > > default-configs/x86_64-softmmu.mak | 1 + > > hw/char/Makefile.objs | 3 ++- > > 15 files changed, 16 insertions(+), 1 deletion(-) > > Ignorant question: what about the CONFIG_SERIAL in pci.mak? Should it > trigger CONFIG_SERIAL_ISA, too? If not, should the commit message > explain why not?
Ah, yes, it probably should. I think I left it out because many of
the PCI platforms also explicitly enable CONFIG_SERIAL, but putting
CONFIG_SERIAL_ISA in pci.mak is safer for the time being, we can
always turn it off one platform at a time later.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
