On 09.02.2016 22:19, Samuel Thibault wrote: > Thanks for your reviews so far! I have integrated the rest of comments, > the only remaining question for patches 1-3 is about srand() and rand().
I personally don't mind whether you use rand(), g_random_int_range() or g_rand_int_range() here, but of course, the ..._range() functions seem to fit more naturally here. I just think that if you use rand() or g_random_int_range(), the rng should be seeded from the main() function, not from the slirp code. Thomas
