On Sun, 14 Feb 2016 18:17:05 +0100
Paolo Bonzini <pbonz...@redhat.com> wrote:
> Make the API more similar to the regular virtqueue API. This will
> help when modifying the code to not use vring.c anymore.
>
> Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> ---
> hw/block/dataplane/virtio-blk.c | 3 ++-
> hw/virtio/dataplane/vring.c | 3 +--
> include/hw/virtio/dataplane/vring.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c
> index 4308d9f..157e8b8 100644
> --- a/hw/virtio/dataplane/vring.c
> +++ b/hw/virtio/dataplane/vring.c
> @@ -175,7 +175,7 @@ void vring_disable_notification(VirtIODevice *vdev, Vring
> *vring)
> *
> * Return true if the vring is empty, false if there are more requests.
> */
I realize that this is going away, but the comment above is now a bit
irritating :)
> -bool vring_enable_notification(VirtIODevice *vdev, Vring *vring)
> +void vring_enable_notification(VirtIODevice *vdev, Vring *vring)
> {
> if (virtio_vdev_has_feature(vdev, VIRTIO_RING_F_EVENT_IDX)) {
> vring_avail_event(&vring->vr) = vring->vr.avail->idx;
> @@ -183,7 +183,6 @@ bool vring_enable_notification(VirtIODevice *vdev, Vring
> *vring)
> vring_clear_used_flags(vdev, vring, VRING_USED_F_NO_NOTIFY);
> }
> smp_mb(); /* ensure update is seen before reading avail_idx */
> - return !vring_more_avail(vdev, vring);
> }
>
> /* This is stolen from linux/drivers/vhost/vhost.c:vhost_notify() */
Otherwise
Acked-by: Cornelia Huck <cornelia.h...@de.ibm.com>
