On 12.02.2016 17:33, Edgar E. Iglesias wrote:
> From: "Edgar E. Iglesias" <edgar.igles...@xilinx.com>
>
> Use extract32 instead of open coding the bit masking when decoding
> is_signed and is_extended. This streamlines the decoding with some
> of the other ldst variants.
>
> No functional change.
>
> Signed-off-by: Edgar E. Iglesias <edgar.igles...@xilinx.com>
Reviewed-by: Sergey Fedorov <serge.f...@gmail.com>
> ---
> target-arm/translate-a64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-arm/translate-a64.c b/target-arm/translate-a64.c
> index 7f65aea..bf31f8a 100644
> --- a/target-arm/translate-a64.c
> +++ b/target-arm/translate-a64.c
> @@ -2117,8 +2117,8 @@ static void disas_ldst_reg_imm9(DisasContext *s,
> uint32_t insn)
> return;
> }
> is_store = (opc == 0);
> - is_signed = opc & (1<<1);
> - is_extended = (size < 3) && (opc & 1);
> + is_signed = extract32(opc, 1, 1);
> + is_extended = (size < 3) && extract32(opc, 0, 1);
> }
>
> switch (idx) {
