alvise rigo <a.r...@virtualopensystems.com> writes: > On Fri, Feb 19, 2016 at 12:44 PM, Alex Bennée <alex.ben...@linaro.org> wrote: >> >> Alvise Rigo <a.r...@virtualopensystems.com> writes: >> >>> This is the seventh iteration of the patch series which applies to the >>> upstream branch of QEMU (v2.5.0-rc4). >>> >>> Changes versus previous versions are at the bottom of this cover letter. >>> >>> The code is also available at following repository: >>> https://git.virtualopensystems.com/dev/qemu-mt.git >>> branch: >>> slowpath-for-atomic-v7-no-mttcg >> >> OK I'm done on this review pass. I think generally we are in pretty good >> shape although I await to see what extra needs to be done for the MTTCG >> case. > > Hi Alex, > > Thank you for this review. Regarding the extra needs and integration > with the MTTCG code, I've made available at this address [1] a working > branch with the two patch series merged together. The branch boots > fine Linux on both aarch64 and arm architectures. There is still that > known issue with virtio, that Fred should fix soon. Let me know your > first impressions.
Does the virtio problem it go away if you drop the top patch (as per my last email)? > > [1] https://git.virtualopensystems.com/dev/qemu-mt.git (branch > "merging-slowpath-v7-mttcg-v8-wip") Thanks I'll have a look next week. > > Thank you, > alvise > >> >> We are coming up to soft-freeze on 1/3/16 and it would be nice to get >> this merged by then. As it is a fairly major chunk of work it would need >> to get the initial commit by that date. >> >> However before we can get to that stage we need some review from the >> maintainers. For your next version can you please: >> >> - Drop the RFC tag, I think we have had enough comment ;-) >> - Make sure you CC the TCG maintainers (Paolo, Peter C and Richard >> Henderson) >> - Also CC the ARM maintainers (Peter M) >> - Be ready for a fast turnaround >> >> Paolo/Richard, >> >> Do you have any comments on this iteration? >> >> -- >> Alex Bennée -- Alex Bennée