On 02/22/2016 12:35 PM, Andreas Färber wrote: > Am 22.02.2016 um 18:06 schrieb Matthew Rosato: >> In preparation for hotplug, defer some CPU initialization >> until the device is actually being realized. >> >> Signed-off-by: Matthew Rosato <mjros...@linux.vnet.ibm.com> >> --- >> target-s390x/cpu.c | 9 ++++++--- >> 1 file changed, 6 insertions(+), 3 deletions(-) > > Looks reasonable on a brief sight, > > Reviewed-by: Andreas Färber <afaer...@suse.de> > > What is env->cpu_num used for? In particular, have you thought about > linux-user creating multiple CPUs and possibly destroying them again? >
env->cpu_num is intended to map to the s390x architecture concept of a cpu address, which is a numeric ID used to differentiate between CPUs when a targeted event occurs (like an unsolicited interrupt that must be handled on behalf of a particular CPU). s390x architecture currently cannot tolerate CPU destruction. Matt
