On 26/02/2016 00:23, Marc-André Lureau wrote:
> Hi
>
> On Fri, Feb 26, 2016 at 12:10 AM, Paolo Bonzini <pbonz...@redhat.com> wrote:
>>
>>
>> On 23/02/2016 15:24, Gerd Hoffmann wrote:
>>> qemu_mutex_lock(&ssd->lock);
>>> + if (c) {
>>> + cursor_get(c);
>>> + }
>>> + cursor_put(ssd->cursor);
>>> + ssd->cursor = c;
>>> ssd->hot_x = c->hot_x;
>>> ssd->hot_y = c->hot_y;
>>
>> Coverity complains that this would dereference a NULL c, and I think
>> it's right; either an unlock+return is missing, or the "if" is unnecessary.
>>
>
> Oops, I don't know why there is a if there, it's unnecessary indeed.
> ACK if you did the patch already ;)
No I didn't. :)
Paolo
