On 02/25/2016 09:22 AM, Bharata B Rao wrote: > Implement query cpu-slots that provides information about hot-plugged > as well as hot-pluggable CPU slots that the machine supports. > > TODO: As Eric suggested use enum for type instead of str. > TODO: @hotplug-granularity probably isn't required.
I guess this is still marked TODO because the series is still RFC? > > Signed-off-by: Bharata B Rao <bhar...@linux.vnet.ibm.com> > --- > +++ b/qapi-schema.json > @@ -4083,3 +4083,88 @@ > ## > { 'enum': 'ReplayMode', > 'data': [ 'none', 'record', 'play' ] } > + > +## > +# @CPUInfo: > +# > +# Information about CPUs > +# > +# @arch-id: Arch-specific ID for the CPU. > +# > +# @type: QOM type of the CPU. > +# > +# @thread: Thread ID of the CPU. > +# > +# @core: Core ID of the CPU. > +# > +# @socket: Socket ID of the CPU. > +# > +# @node: NUMA node to which the CPU belongs. Please add the '#optional' tag to the fields which are not always present. > +# > +# @qom-path: QOM path of the CPU object > +# > +# Since: 2.6 > +## > + > +{ 'struct': 'CPUInfo', > + 'data': { 'arch-id': 'int', > + 'type': 'str', The TODO in the commit message mentions that this should be converted to an enum. > + '*thread': 'int', > + '*core': 'int', > + '*socket' : 'int', > + '*node' : 'int', > + '*qom-path': 'str' > + } But looking better than the previous round. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature