Marc-André Lureau <marcandre.lur...@gmail.com> writes: > Hi > > On Mon, Feb 29, 2016 at 7:40 PM, Markus Armbruster <arm...@redhat.com> wrote: >> Use ivshmem-plain instead. >> >> Signed-off-by: Markus Armbruster <arm...@redhat.com> >> --- >> hw/misc/ivshmem.c | 15 +-------------- >> 1 file changed, 1 insertion(+), 14 deletions(-) >> >> diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c >> index 33b6842..f6fce15 100644 >> --- a/hw/misc/ivshmem.c >> +++ b/hw/misc/ivshmem.c >> @@ -1197,8 +1197,7 @@ static void ivshmem_realize(PCIDevice *dev, Error >> **errp) >> } >> >> if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) { >> - error_setg(errp, >> - "You must specify either 'shm', 'chardev' or >> 'x-memdev'"); >> + error_setg(errp, "You must specify either 'shm' or 'chardev'"); >> return; >> } > > You could also get rid of hostmem checks here: > > - if (!!s->server_chr + !!s->shmobj + !!s->hostmem != 1) { > + if (!!s->server_chr + !!s->shmobj > 1) { > error_setg(errp, "You must specify either 'shm' or 'chardev'"); > return; > } > > - if (s->hostmem) { > - if (s->sizearg) { > - g_warning("size argument ignored with hostmem"); > - } > - } else if (s->sizearg == NULL) { > + if (s->sizearg == NULL) {
Will do. No idea how I missed those :) > otherwise, looks good Thanks!