On Thu, Mar 03, 2016 at 12:55:51PM +0100, Andrew Jones wrote: > On Thu, Mar 03, 2016 at 04:21:11PM +0800, Peter Xu wrote: > > + > > +GICCapabilityList *qmp_query_gic_capability(Error **errp); > > I don't know anything about QMP, so just offering a superficial > review comment. Is the prototype necessary here? It seems redundant, > considering the function is defined right below. > > drew
I added this to avoid a "missing prototype" warning. However found the correct way to do it is possibly to include "qmp-commands.h" in target-arm/machine.c. Thanks to point out! Will fix. Peter
