On 03/04/2016 08:49 AM, Eric Blake wrote: > Oh, I see you DID include a S-o-b, but in the subject line of the patch > instead of the commit body. Which still needs work. You need a > one-line summary as the subject, not your S-o-b, so the commit message > should look more like: > > thunk: Replace malloc with g_malloc() > > This replacement was suggested as part of the bite-sized tasks. > > Signed-off-by: Sarah Khan <[email protected]>
Oh, and I'd be remiss if I did not add: This looks like your first contribution. Welcome to the QEMU community, and hope you enjoy it here! Keep in mind that email is a bad medium for expressing emotion, and that reviewers tend to point out flaws without looking for the good; but in reality, we are grateful when someone steps up to help with the bite-sized tasks. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
