> >> This suggests we are incorrectly coalescing writes, and we should > >> actually be > >> notifying qemu when (at least) he first write occurs. If we aren't > >> outputting > >> anything we don't want to be waking up periodically just to flush an > >> empty > >> MMIO buffer. > > > > That is completely unrelated to this patch though. The patch doesn't > > change mmio flush behaviour at all. And the periodic wakeup was there > > even before the mmio flush patch was added. Even without gui, > > although I can't see a obvious reason for it ... > > Agreed. Regardless of the periodic mmio flush, having a separate > nographic timer isn't terribly helpful IMHO.
I guess what I was objecting to is formalising this a "gui_timer" rather than "arbitrary_polling_hack_timer". Paul