On Thu, Mar 3, 2016 at 1:27 PM, Alistair Francis <alistair.fran...@xilinx.com> wrote: > On Mon, Feb 29, 2016 at 4:26 AM, Alex Bennée <alex.ben...@linaro.org> wrote: >> >> Alistair Francis <alistair.fran...@xilinx.com> writes: >> >>> This patch series is based on Peter C's original register API. His >>> original cover letter is below. >>> >>> I have added a new function memory_region_add_subregion_no_print() which >>> stops memory regions from being printed by 'info mtree'. This is used to >>> avoid evey register being printed when running 'info mtree'. >> >> OK I've finished my pass of v4. In general I think it is looking OK. I >> think the main things that remain to be addressed are: >> >> - not breaking up MemoryRegions for each individual register >> - adding some access MACROs to aid reading/grepping of macro defined >> registers >> - some patches have un-related changes in them >> >> Let me know when v5 is ready ;-) > > Thanks for your review, I'll go through and address your comments. >
I have made some large changes to the API infrastructure so now only a single memory region is created. The individual registers still have all of the control (instead of moving it to a central area) as I think it allows more customisations in the future if required. Thanks, Alistair
