Hi, > +/* Here we just expose minimal host bridge offset subset. */ > +static const IGDHostInfo igd_host_bridge_infos[] = { > + {0x08, 2}, /* revision id */ > + {0x2c, 2}, /* sybsystem vendor id */ > + {0x2e, 2}, /* sybsystem id */
Can anyone clarify where this comes from? Setting the subsystem id without also setting the pci id looks wrong, given that each pci id has its own subsystem id namespace. Testing (with alex vfio patches) shows that dropping this seems to have no bad effects. Things are still working fine of we only set these ... > + {0x50, 2}, /* SNB: processor graphics control register */ > + {0x52, 2}, /* processor graphics control register */ > + {0xa4, 4}, /* SNB: graphics base of stolen memory */ > + {0xa8, 4}, /* SNB: base of GTT stolen memory */ ... gfx registers in host bridge pci config space. thanks, Gerd