On 06/15/10 15:34, Paolo Bonzini wrote: > On 06/15/2010 01:04 PM, jes.soren...@redhat.com wrote: >> From: Jes Sorensen<jes.soren...@redhat.com> >> >> No need for kvm_init() stub in kvm-stub.c as already defined in >> qemu-kvm.h > > Why not keep the other one and match upstream? Instead, I'd remove this > one and move kvm_inject_x86_mce to kvm-stub.c. > > Files that upstream compiles only once will be compiled only without > CONFIG_KVM, and will always call the stubs if these are in qemu-kvm.h.
You're right, time for a v3 of the patch.... Cheers, Jes
