On 14/03/2016 17:16, Denis V. Lunev wrote: >> BTW, I'm not against adding this to QEMU in general - just pointing out >> that in the context of libvirt usage reference in the commit message, >> it is not really needed. I'm totally ambivalent wrt adding this to QEMU >> for benefit of non-libvirt usage. > > I see. This just requires very clear commit message from my side. > Thank you for a discussion.
I think this is not a compelling usage of the logging subsystem; QMP is always used through a character device, and character devices already have a logging mechanism. Adding a mechanism that looks for '\n' in the data written to a character device and emits a timestamp on the next character would be a useful addition. I'd be entirely happy with adding it now, it should be safe enough that we can do it during soft freeze. Paolo
