On 03/15/2016 03:04 PM, Jason Wang wrote: > > > On 03/15/2016 01:38 PM, Zhang Chen wrote: >> Filter-mirror is a netfilter plugin. >> It gives qemu the ability to mirror >> packets to a chardev. >> >> v9: >> - add qmp("{ 'execute' : 'query-status'}") >> before iov_send() and change pipe >> to socket in test-filter-mirror.c > > Want to merge the series, but it doesn't build on my laptop (and another > machine). > > CHK version_gen.h > CC net/filter-mirror.o > In file included from /home/devel/git/qemu/include/net/filter.h:12:0, > from net/filter-mirror.c:12: > /home/devel/git/qemu/include/qom/object.h:300:39: error: unknown type > name ‘Error’ > Error **errp);
I think he doesn't use the newest commit. After the commit 2744d920, we should include qemu/osdep.h first Thanks Wen Congyang > >> v8: >> - The outdev of filter-mirror test changed >> from -chardev socket to -chardev pipe >> >> v7: >> - fix mktemp() to mkstemp() >> >> v6: >> - Address Jason's comments. >> >> v5: >> - Address Jason's comments. >> >> v4: >> - Address Jason's comments. >> >> v3: >> - Add filter-mirror unit test according >> to Jason's comments >> - Address zhanghailiang's comments. >> - Address Jason's comments. >> >> v2: >> - Address zhanghailiang's comments. >> - Address Eric Blake's comments. >> - Address Yang Hongyang's comments. >> - Address Dave's comments. >> >> v1: >> initial patch. >> >> >> Zhang Chen (2): >> net/filter-mirror:Add filter-mirror >> tests/test-filter-mirror:add filter-mirror unit test >> >> net/Makefile.objs | 1 + >> net/filter-mirror.c | 181 >> +++++++++++++++++++++++++++++++++++++++++++++ >> qemu-options.hx | 5 ++ >> tests/.gitignore | 1 + >> tests/Makefile | 2 + >> tests/test-filter-mirror.c | 92 +++++++++++++++++++++++ >> vl.c | 3 +- >> 7 files changed, 284 insertions(+), 1 deletion(-) >> create mode 100644 net/filter-mirror.c >> create mode 100644 tests/test-filter-mirror.c >> > > > > . >