Hi Greg, Thanks for your comments and for taking the time. 2016-03-14 12:27 GMT+01:00 Greg Kurz <gk...@linux.vnet.ibm.com>: > > SoB tag is missing.
I will add this in the future. > > +static void virtio_net_validate_queue_limit(uint16_t *queue_size) > > +{ > > + if (*queue_size > VIRTIO_QUEUE_SIZE_MAX) { > > + error_report("queue-size: %d, exceeds maximum allowed > > queue-size(%d)," > > + "queue-size set to %d", *queue_size, > > VIRTIO_QUEUE_SIZE_MAX, > > It is encouraged to keep format strings passed to error_report() on 1 line. It > is easier to grep. Makes sense, I will fix this. > > + VIRTIO_QUEUE_SIZE_MAX); > > + *queue_size = VIRTIO_QUEUE_SIZE_MAX; > > + } else if (*queue_size < VIRTIO_QUEUE_SIZE_MIN) { > > + error_report("queue-size: %d, below minimum allowed > > queue-size(%d)," > > + "queue-size set to %d", *queue_size, > > VIRTIO_QUEUE_SIZE_MIN, > > Same remark. See previous comment. Thanks, Patrik