On Fri, 03/11 15:11, Alex Bennée wrote: > > Fam Zheng <f...@redhat.com> writes: > > > This adds a group of make targets to run docker tests, all are available > > in source tree without running ./configure. > > > > The usage is shown by "make docker". > > > > Besides the fixed ones, dynamic targets for building each image and > > running each test in each image are generated automatically by make, > > scanning $(SRC_PATH)/tests/docker/ files with specific patterns. > > > > Alternative to manually list particular targets (docker-run-FOO@BAR) > > set, you can control which tests/images to run by filtering variables, > > TESTS= and IMAGES=, which are expressed in Makefile pattern syntax, > > "foo% %bar ...". For example: > > > > $ make docker-run IMAGES="ubuntu fedora" > > I thought I mentioned this last time, it needs fixing in the commit > message: > > 15:05 alex@zen/x86_64 [qemu.git/review/docker-v3] >make docker-run > IMAGES="ubuntu fedora" > make: *** No rule to make target `docker-run'. Stop.
My bad! > > > > > Unfortunately, it's impossible to propagate "-j $JOBS" into make in > > containers, however since each combination is made a first class target > > is the top Makefile, "make -j$N docker-run" still parallels the tests > > coarsely. > > > > Instead of providing a live version of the source tree to the docker > > container we snapshot it with git-archive. This ensure the tree is in a > > pristine state for whatever operations the container is going to run on > > them. > > > > Uncommitted changes known to files known by the git index will be > > included in the snapshot if there are any. > > > > Signed-off-by: Fam Zheng <f...@redhat.com> > > Signed-off-by: Alex Bennée <alex.ben...@linaro.org> > > fix the commit message and have a: > > Reviewed-by: Alex Bennée <alex.ben...@linaro.org> Thanks! Fam